Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully tokenize the focus ring #1166

Open
1 of 3 tasks
thrbnhrtmnn opened this issue Oct 2, 2024 · 0 comments
Open
1 of 3 tasks

Fully tokenize the focus ring #1166

thrbnhrtmnn opened this issue Oct 2, 2024 · 0 comments
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

Description / User story

When looking at the checkbox #1156 was created. After discussing the tokens for the focus ring, we decided to create this ticket and think about the current solution.

We should invest some time to see if we should fully tokenize the focus ring.

The current approach would not allow users to define a focus ring without a radius for a checkbox that has a radius.

Figma doesn't allow a outline-offset, which we are using in code for the checkbox.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • Research has been done about tokenizing the focus ring
  • A decision has been made, how to proceed

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant