Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow number attributes to be written with and without quotations #829

Closed
2 tasks done
thrbnhrtmnn opened this issue Jan 24, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Milestone

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jan 24, 2024

Description / User Story

After fixing the show code function by changing the render function last Friday, we noticed with #819 that attributes that are numbers are not working. After some investigation by @ChristianHoffmannS2 and @bar-tay , we found out that currently numbers only work as attributes, when they are written without quotation marks. <input value=20> works, but <input value=“20”> does not currently work. We should find a way that numbers as attributes work both with and without quotation marks.


Acceptance Criteria

  • Numbers at attributes like the offset in the Tooltip component work with quotation marks
  • Numbers at attributes like the offset in the Tooltip component work without quotation marks

Background information

  • Add relevant information here
  • ...
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Jan 24, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Beta Release milestone Jan 24, 2024
@bar-tay bar-tay self-assigned this Jan 26, 2024
@ChristianHoffmannS2
Copy link
Collaborator

@bar-tay we actually planned to solve this during the pair programming session.

there is already a draft branch for that, including informations how far we got and whats left
#837

@thrbnhrtmnn
Copy link
Contributor Author

As discussed with Christian today this task can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

3 participants