Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly containing style changes & refactor; including
OpenSSL
build requirement for Fedora and Ubuntu inREADME.md
.Some changes include:
MythraResult<T>
type, rather than passingResult<T, Box<dyn std::errror::Error>>
around.src/engine.rs
tosrc/engine/mod.rs
.README.md
.Roadmap:
impl FreeMP3Cloud for EngineTrait { ... }
.type.rs
toengine/mod.rs
.parse_single_music
has return typeOption
whileEngineTrait
hasMythraResult
.pub async
.music.rs
mod includingMusic
structs/traits implementations.rustdoc
.src/api.rs:18
.bulid.rs
to handle OpenSSL versions and platforms.utils.rs
.src/api.rs:search
, it shouldn't be repeated insrc/engine/mod.rs:search_all
.download.rs:download_from_url
should return aResult
type indicating if download failed or succeeded.error.rs
.