Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the development lifecycle step of a command #6

Closed
l0rd opened this issue Feb 4, 2020 · 2 comments
Closed

Specify the development lifecycle step of a command #6

l0rd opened this issue Feb 4, 2020 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 4, 2020

We need to agree on a convention to specify the step(s) of the development lifecycle a command belongs to. For example a given command will be used during the build step and another one is used for the run step. Tools like odo and che will then leverage this information to infer the sequence of the commands that need to be run.

A possible convention we can agree on is to specify the lifecycleStep as command annotation:

commands:
  - exec:
      annotations:
        lifecycleStep: build
      commandLine: "./build.sh"
      component: build-container
  - exec:
      annotations:
        lifecycleStep: run
      commandLine: "./run.sh"
      component: runtime-container
@l0rd l0rd added the kind/enhancement New feature or request label Feb 4, 2020
@l0rd l0rd mentioned this issue Feb 5, 2020
28 tasks
@davidfestal
Copy link
Collaborator

Is it a duplicate of #27 ?

Additionally, about the syntax proposed here: do we assume annotations would be some sort of free map (without a sub-schema) ?
Why not add this as a real field in the command schema itself ?

@l0rd
Copy link
Contributor Author

l0rd commented Mar 3, 2020

Closing as duplicate of #27

@l0rd l0rd closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants