broken nodejs-agular devfile

[kadel]

/kind bug

The route is returning Invalid Host header

$ odo create nodejs-angular --starter nodejs-angular-starter
Devfile Object Creation
 ✓  Checking if the devfile for "nodejs-angular" exists on available registries [35929ns]
 ✓  Creating a devfile component from registry "StagingRegistry" [1s]
Validation
 ✓  Validating if devfile name is correct [35290ns]
 ✓  Validating the devfile for odo [4ms]

Starter Project
 ✓  Downloading starter project nodejs-angular-starter from https://github.com/devfile-samples/devfile-stack-nodejs-angular.git [470ms]
 ✓  Updating the devfile with component name "nodejs-angular-asdf-loix" [481899ns]

Please use `odo push` command to create the component with source deployed

$ odo push

Validation
 ✓  Validating the devfile [30790ns]

Creating Services for component nodejs-angular-asdf-loix
 ✓  Services are in sync with the cluster, no changes are required

Creating Kubernetes resources for component nodejs-angular-asdf-loix
 ✓  Waiting for component to start [16s]
 ✓  Links are in sync with the cluster, no changes are required
 ✓  Waiting for component to start [1ms]

Applying URL changes
 ✓  URL http: http://http-c91c0c50-asdf.apps-crc.testing/ created

Syncing to component nodejs-angular-asdf-loix
 ✓  Checking files for pushing [6ms]
 ✓  Syncing files to the component [182ms]

Executing devfile commands for component nodejs-angular-asdf-loix
 ✓  Executing install command "yarn install" [22s]
 ✓  Executing run command "yarn start", if not running [1s]

Pushing devfile component "nodejs-angular-asdf-loix"
 ✓  Changes successfully pushed to component

$ curl http://http-c91c0c50-asdf.apps-crc.testing/ 
Invalid Host header%                                                                                                                                                   
$ curl http://http-c91c0c50-asdf.apps-crc.testing/ 
Invalid Host header%                             

[kadel]

tests on PR where this devfile was updated failed on the same error devfile/registry#91 (comment)

[johnmcollier]

@schultzp2020 can you take a look?

The CI doesn't seem to be reporting this as a failure since it appears to still be returning a 200 status code? We'll probably also need to look into improving our failure detection logic a bit (outside of this issue).