Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.22, unpin envtest and goimports #1316

Open
AObuchow opened this issue Sep 11, 2024 · 1 comment
Open

Upgrade to go 1.22, unpin envtest and goimports #1316

AObuchow opened this issue Sep 11, 2024 · 1 comment

Comments

@AObuchow
Copy link
Collaborator

We've had to pin envtest and goimports because we're currently using go 1.20 throughout the repo.

Originally, this was because go 1.22 was not available for the stable release of Fedora. Now, go 1.22 is available in Fedora 40 so we should finally upgrade the go version used throughout the repo.

@AObuchow
Copy link
Collaborator Author

AObuchow commented Sep 11, 2024

Update: Unfortuantely, it turns out we can't upgrade to go 1.22 yet because though it's available on Fedora (I'm running 1.22.5) it's not available yet for the go-toolset image we use in our Dockerfiles. The latest version of go-toolset goes up to go 1.21.11.

Since goimports v0.25.0 & latest envtest require go >= 1.22.0, for now we could at best only update to go 1.21.11. Both of these tools would have to remain pinned :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant