Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding arbitrary fields in workspace deployment's containers via attribute #945

Closed
amisevsk opened this issue Oct 4, 2022 · 0 comments · Fixed by #944
Closed
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Oct 4, 2022

Description

Add attribute container-overrides which can be applied to container components to specify container fields not available in the DevWorkspace spec. This would allow, for example, users to specify extended resources for container components, which are currently not available in the API:

components:
  - name: go
    attributes:
      container-overrides: {"resources":{"limits":{"nvidia.com/gpu": "1"}}}
    container:
      image: ...

Additional context

See discussion in devfile/api: devfile/api#920
Follow up to #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant