Feature/AMP-30574/sectors mapping #4199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API: endpoints
Improvements in Endpoints. Part of admin page
CRUD Sector Mappings and cleaning code
Updating all activities
Job files
Fix CRUD saving changes
Cleaning of files and functionalities related with "Update all activities" and Job updater
Functionality in Activity Form
Deleting secondary sectors mapped in Activity Form if an primary sector was deleted.
jdeanquin-dg
changed the title
brianbrix
reviewed
Dec 28, 2023
| @@ -34,6 +31,17 @@ public static void requireValid(Object obj) { | |||
| } | |||
| } | |||
|
|
|||
| public static void valuesValid(Collection possibleValues, Object value) { | |||
There was a problem hiding this comment.
Can we add something like if (possibleValues == null) { throw new IllegalArgumentException("possibleValues cannot be null"); } to avoid a nullpointer exception
brianbrix
reviewed
Dec 28, 2023
brianbrix
reviewed
Dec 28, 2023
brianbrix
reviewed
Dec 29, 2023
| queryString = "select asm from " + AmpSectorMapping.class.getName() + " asm"; | ||
| qry = session.createQuery(queryString); | ||
| col = qry.list(); | ||
| session.flush(); |
There was a problem hiding this comment.
I was wondering what get if we dont flush after a select operation. Because typically we should not flush after a select since there is no use for synchronizing the persistence context.. I think we should check this and rectify it.
Observations made by Brian
jdeanquin-dg
previously approved these changes
Jun 11, 2024
…g' into feature/AMP-30574/sectors-mapping
brianbrix
force-pushed
the
feature/AMP-30574/sectors-mapping
branch
from
75845e2 to
cef4fb2
Compare
brianbrix
force-pushed
the
feature/AMP-30574/sectors-mapping
branch
from
e4d6ea0 to
04e7a25
Compare
brianbrix
force-pushed
the
feature/AMP-30574/sectors-mapping
branch
from
04e7a25 to
32ee591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.