Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Build and Test via Github Actions #1389

Open
Snailedlt opened this issue Sep 22, 2022 · 2 comments
Open

[FEATURE REQUEST] Build and Test via Github Actions #1389

Snailedlt opened this issue Sep 22, 2022 · 2 comments
Labels
devops Use this label for devops related enhancements good first issue Help new contributors find good first issue

Comments

@Snailedlt
Copy link
Collaborator

Would be nice if each PR triggered a build and test of the branch. That way it would be a bit more robust, and less likely to let through bugs that crash the site. Especially useful for dependency updates.

As referenced here:

@Panquesito7 did you test it locally? Also, did you see the changelog?

I haven't tested it locally (we could use Gitpod to deploy the page, though). The changelog or commits seem to be to fix a security issue. https://github.com/devicons/devicon/security/dependabot/6

No need to deploy imo. Just a simple build and run would suffice. If it runs, and the code checks are all green, it probably should work.

We could add a build step to the CodeQL workflow though. Maybe just add npm ci, npm build and npm test?
Can probably just be added as a replacement of these lines:

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1
# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

Originally posted by @Snailedlt in #1385 (comment)

@Snailedlt Snailedlt added the devops Use this label for devops related enhancements label Sep 22, 2022
@Panquesito7
Copy link
Member

We could try using that to verify all runs properly. 🙂
Do you want to make a PR or mark it as a good first issue?

@Snailedlt Snailedlt added the good first issue Help new contributors find good first issue label Sep 23, 2022
@Snailedlt
Copy link
Collaborator Author

We could try using that to verify all runs properly. 🙂 Do you want to make a PR or mark it as a good first issue?

Definitely a good first issue, so I'll just label it as that, and if no one else does it, I'll muster up the strength to do it myself 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements good first issue Help new contributors find good first issue
Projects
None yet
Development

No branches or pull requests

2 participants