Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Add Devicons/Devicon to Nerdfonts #1420

Open
1 task done
Snailedlt opened this issue Oct 3, 2022 · 9 comments
Open
1 task done

[OTHER] Add Devicons/Devicon to Nerdfonts #1420

Snailedlt opened this issue Oct 3, 2022 · 9 comments
Labels
discussion Use this label for community discussions about changes/features/..

Comments

@Snailedlt
Copy link
Collaborator

I have searched through the issues and didn't find my problem.

  • Confirm

What would you like to share?

It would be nice if Devicons was updated in Nerdfonts from the old unmaintained vorillaz/devicons repo to this one. I added some comments to the issue over at ryanoasis/nerd-fonts asking in what way they'd like to add it: ryanoasis/nerd-fonts#615 (comment)

While we wait for an answer we might as well discuss it here too :)

Additional information

No response

@Snailedlt Snailedlt added discussion Use this label for community discussions about changes/features/.. awaiting triage Awaiting triage from a maintainer labels Oct 3, 2022
@Snailedlt Snailedlt changed the title [OTHER] Consider helping add devicons/devicon to Nerdfonts [OTHER] Add Devicons to Nerdfonts Oct 3, 2022
@Snailedlt Snailedlt changed the title [OTHER] Add Devicons to Nerdfonts [OTHER] Add Devicons/Devicon to Nerdfonts Oct 3, 2022
@Snailedlt
Copy link
Collaborator Author

@Panquesito7 @BenSouchet @kilian-paquier @lunatic-fox
Would love to get some of your opinions on this!

@BenSouchet
Copy link
Contributor

Hi,
Don't know if it's our "job" to update the version that is used by Nerdfonts, but if it's not to difficult / time consuming for us to update it why not. It's better if users have the latest version of the work done by the Devicon community.

Waiting for the comment(s) of others here and also the comment(s) of the maintainers of Nerdfonts

@Snailedlt
Copy link
Collaborator Author

@BenSouchet Agreed! It's not our job, but would be cool regardless :)

@lunatic-fox
Copy link
Contributor

First, thanks for marking me into this discussion.

I agree with @BenSouchet. I like you took the first step by asking how to make this addition properly. And yeah, I also think it'll have a compatibility problem when adding from Vorillaz repository, but let's wait Nerdfonts maintainers response on that.

It also seems that users have been wanting and waiting for this for quite some time. 😃

@Finii
Copy link

Finii commented Oct 4, 2022

It's not our job, but would be cool regardless

👍

Whatever, I can certainly help to whichever degree you like it :)
In fact even with introducing codepoint stability (*) the job is not very hard.

(*) Font-Logos introduced a small script with this commit, and I used their ideas for this script that generates a codepoint-guaranteed font from SVGs for 'Nerd Fonts "Original"' symbols font.

@Snailedlt Snailedlt removed the awaiting triage Awaiting triage from a maintainer label Oct 15, 2022
@Snailedlt
Copy link
Collaborator Author

I'll create an issue on introducing codepoint stability

@Panquesito7
Copy link
Member

Kinda late, but I agree with the comments above. :)

@pysan3
Copy link

pysan3 commented Aug 14, 2023

Hate to be this guy, but any update on this? Nerdfont has successfully upgraded to v3.0.0 so I think it'll be a good opportunity to get this resolved.

Reading the linked issues and comments, it seems that #1516 is the first thing that needs to be worked on in order to merge it into nerdfont.

Thank you.

@Snailedlt
Copy link
Collaborator Author

@pysan3 Sadly there hasn't been any work on this other than creating the issue you linked to. For now the top priority is releasing what we have on the develop branch.
After that I wanna spend my time migrating to trunk based development (only one main branch instead of main + develop).

That said we're open to PRs, so if you want feel free to make one. I'll make time to review it since it's an important feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Use this label for community discussions about changes/features/..
Projects
None yet
Development

No branches or pull requests

6 participants