Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] vscode-*-wordmark.svg contains raster image #1517

Closed
1 task done
cyberalien opened this issue Nov 19, 2022 · 2 comments · Fixed by #1524
Closed
1 task done

[BUG] vscode-*-wordmark.svg contains raster image #1517

cyberalien opened this issue Nov 19, 2022 · 2 comments · Fixed by #1524
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Comments

@cyberalien
Copy link
Contributor

I have searched through the issues and didn't find my problem.

  • Confirm

Bug description

vscode-*-wordmark.svg images contain <image> tag with PNG image, used as mask

Possible fixes or solutions

Remove it. It is used for text shadow, which is not needed in a vector image.

Additional information

No response
@cyberalien cyberalien added the bug Use this label for pointing out bugs label Nov 19, 2022
@cyberalien
Copy link
Contributor Author

cyberalien commented Nov 19, 2022 •
edited
Loading

Same with few more icons, not sure if separate issues are needed for each one of them:

@iuridiniz iuridiniz mentioned this issue Nov 19, 2022
Closed
@cyberalien
Copy link
Contributor Author

Additionally, vscode-*-wordmark icons have bad logo shapes, incorrectly aligned:

vscode-bugged

This was referenced Nov 20, 2022
Merged
Closed
@Snailedlt Snailedlt mentioned this issue Nov 20, 2022
Open
1 task
@Snailedlt Snailedlt added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Dec 3, 2022
@Snailedlt Snailedlt linked a pull request Dec 3, 2022 that will close this issue
update icon: vscode (original, plain, original-wordmark, plain-wordmark) #1524
Merged
1 task
@github-actions github-actions bot closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update icon: vscode (original, plain, original-wordmark, plain-wordmark) cyberalien/devicon
2 participants
@cyberalien @Snailedlt