#827: Made status commandlet available outside of IDE_HOME #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the status commandlet not require IDE_HOME or IDE_ROOT Wrote a test for given szenario
Test for status commandlet added
hohwille
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
@WorkingAmeise thanks for fixing the problem and also adding a test. 👍
I left some review comments. Please address them so we can merge.
cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/StatusCommandletTest.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/StatusCommandlet.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 11, 2024 10:29
Changed StatusCommandlet.idIdeHomeRequired() to return the value of StatusCommandlet.isIdeRootRequired(), since one only makes sense with the other. Removed accidentaly duplicated line in AbstractIdeContext.applyAndRun(). Changed test to work on every machine and if the User does not have IDEasy on drive C:
…-ide-status-fails-outside-IDE_HOME
…ithub.com/WorkingAmeise/IDEasy into bug/827-ide-status-fails-outside-IDE_HOME
Pull Request Test Coverage Report for Build 12300517835Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jan-vcapgemini
approved these changes
Dec 12, 2024
cli/src/test/java/com/devonfw/tools/ide/commandlet/StatusCommandletTest.java
Outdated
Show resolved
Hide resolved
…ndletTest.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #827