Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Eclipse version dependent on JAVA_VERSION #538

Closed
hohwille opened this issue Mar 16, 2021 · 2 comments · Fixed by #660
Closed

Make Eclipse version dependent on JAVA_VERSION #538

hohwille opened this issue Mar 16, 2021 · 2 comments · Fixed by #660
Labels
config should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup)

Comments

@hohwille
Copy link
Member

When ECLIPSE_VERSION is not defined, we use the latest version that we define as a fallback and update frequently when new Eclipse releases come out.
I got feedback from projects that have set their JAVA_VERSION to earlier versions (1.8) but the latest eclipse version does not work with this Java version. I then tell them to also set the ECLIPSE_VERSION accordingly.
IMHO in general projects should have their own settings git repo and maintain versions of their tools explicitly in devon.properties via this git. However, we have the knowlege, what is the latest version of Eclipse that still runs with Java 1.8, etc. The projects might not easily know this. So it would still be relatively easy for us to check the JAVA_VERSION when we determine the default ECLIPSE_VERSION.
WDYT?
Too complicated and overengineered? Or greate feature that we should definetly ship?

@hohwille hohwille added enhancement New feature or request config should be configurable or configuration change eclipse related to Eclipse IDE setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) labels Mar 16, 2021
@maybeec
Copy link
Member

maybeec commented Mar 22, 2021

I would say nothing to invest into.
Basically I fully agree to the case that each project should get a copy of there settings git. I would vote much more to have a proper tutorial in place describing the general application of a devonfw ide to your project.

@SchettlerKoehler

@hohwille hohwille linked a pull request Dec 21, 2021 that will close this issue
@hohwille hohwille added this to the release:2021.12.002 milestone Dec 21, 2021
@hohwille hohwille changed the title Make default Eclipse version dependent on JAVA_VERSION Make Eclipse version dependent on JAVA_VERSION Dec 21, 2021
@hohwille
Copy link
Member Author

I would say nothing to invest into.

All I did now is to detect a misconfiguration if ECLIPSE_VERSION does not fit with JAVA_VERSION and dump out a WARNING so the user can easily notice and fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants