Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍀 Proposal: Update the main.go Template File According to #503 #507

Closed
daniel-hutao opened this issue May 18, 2022 · 5 comments · Fixed by #532
Closed

🍀 Proposal: Update the main.go Template File According to #503 #507

daniel-hutao opened this issue May 18, 2022 · 5 comments · Fixed by #532
Assignees
Labels
good first issue Good for newcomers

Comments

@daniel-hutao
Copy link
Member

daniel-hutao commented May 18, 2022

What would you like to add? Why is this needed?

See #503 for the details. It changed the cmd/plugin/xxx/main.go, So the dtm develop create-plugin diverged from the current codebase.

For more details, please reach out to @daniel-hutao.

image

@daniel-hutao daniel-hutao changed the title 🍀 Proposal: Update the main.go Template File According #503 modification 🍀 Proposal: Update the main.go Template File According #503 Modification May 18, 2022
@daniel-hutao daniel-hutao added the good first issue Good for newcomers label May 18, 2022
@IronCore864 IronCore864 changed the title 🍀 Proposal: Update the main.go Template File According #503 Modification 🍀 Proposal: Update the main.go Template File According to #503 May 18, 2022
@aFlyBird0
Copy link
Member

aFlyBird0 commented May 18, 2022

Template file has been updated in #503 . 😄

Instead, maybe it is also good to add some description of how the plugin is loaded for the beginners.

e.g. The name of DevStreamPlugin is mandatody, so, why is it mandatory and where the code forces a dependency on this variable name? It will be useful for beginners to understand how pulgins work.

Descption can be added to docs or code comments.

I know what the answer is, and I want to give this pr opportunity to new commers.

@daniel-hutao
Copy link
Member Author

cooool @aFlyBird0
I thought the template file was left out, didn't expect you are so "attention to details"

@daniel-hutao
Copy link
Member Author

About the docs or some comments, I think it's better to let you do it. Would you like to?

@aFlyBird0
Copy link
Member

cooool @aFlyBird0
I thought the template file was left out, didn't expect you are so "attention to details"

lol, I just use "global replace".

Then I found template files and develop commond. Code tracing is interesting.

@aFlyBird0
Copy link
Member

About the docs or some comments, I think it's better to let you do it. Would you like to?

Yep! My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants