Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍀 Proposal: main builder / e2e-test failure should trigger an alert #636

Closed
IronCore864 opened this issue May 31, 2022 · 3 comments
Closed
Assignees

Comments

@IronCore864
Copy link
Member

What Would You Like to Add? Why Is This Needed?

If e2e-test is failed or if the main branch builder is failing, we should get a notification. Either Slack or Feishu.

@IronCore864
Copy link
Member Author

e2e failure feishu notificaiton was implemented by @KeHaohaoke

We are migrating to slack, though.

Please implement the same, plus main builder (UT as well, not only e2e), for slack.

@KeHaohaoke
Copy link
Contributor

e2e failure feishu notificaiton was implemented by @KeHaohaoke

We are migrating to slack, though.

Please implement the same, plus main builder (UT as well, not only e2e), for slack.

In addition to sending alerts to feishu, it also includes the url of the actions in the alert message, so that it is easy to click to view the tracking.

@iyear
Copy link
Member

iyear commented Jul 21, 2022

I see that #836 has been merged, if this issue has been resolved, please close it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants