Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(translation): GitOps Toolchain - Chinese Version #715 #720

Closed
wants to merge 12 commits into from
Closed

Conversation

aucker
Copy link
Contributor

@aucker aucker commented Jun 21, 2022

Signed-off-by: aucker aucker@qq.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Translate the gitops.md into Chinese.
Minor fix in commit-messages.zh.md file.

Related Issues

This PR is related to issue #715

New Behavior (screenshots if needed)

Add the translation:
image
image

@aucker aucker requested a review from IronCore864 as a code owner June 21, 2022 05:22
@IronCore864
Copy link
Member

@aucker please sign the DCO. In your previous PR, I mentioned how to do it, and if you forgot, how to fix it.

@IronCore864
Copy link
Member

@aucker Please keep the number indexing in the subtitles consistent.

Either: (without a trailing dot)

  • 1 xxx
  • 1.1 yyy

Example: https://docs.devstream.io/en/latest/development/good-first-issues/

or: (with a trailing dot)

    1. xxx
  • 1.1. xxx

Example: https://docs.python.org/3/tutorial/interpreter.html

Considering most of our existing docs use the former convention, I suggest we follow the same.

@aucker
Copy link
Contributor Author

aucker commented Jun 21, 2022

@aucker please sign the DCO. In your previous PR, I mentioned how to do it, and if you forgot, how to fix it.
Ok, I will refer the manual

2022-03-11 13:39:11 ✔ [SUCCESS] Destroy finished.
```

<!-- todo -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is finished here, right? We shouldn't keep the any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll fix that

@@ -1,3 +1,168 @@
# GitOps 工具链

todo
如果你有兴趣看一个demo,你可以参考
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"如果你有兴趣看一个demo"听起来比较生硬,我的语文不好,或许可以换一种说法?

另外,句末可以有个冒号;下面的列表两个条目之间似乎没有必要添加额外的空行

- `githubactions-golang` -> `github-repo-scaffolding-golang`
- `argocdapp` -> `argocd` 和 `github-repo-scaffolding-golang`

**注意**:这些依赖并不一致,比如当jira-github和github-repo-scaffolding-golang操作的repo不一样时,依赖就消失了。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"依赖就消失了"感觉也不是特别地道的中文说法。Shall we rephrase it?

Copy link
Member

@IronCore864 IronCore864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this PR on hold for now, because we have another issue with the English version of the quickstart. Merging the zh version doesn't make much sense if it can't work perfectly.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants