Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP addresses of clients to log messages #1788

Closed
nabokihms opened this issue Aug 31, 2020 · 3 comments
Closed

Add IP addresses of clients to log messages #1788

nabokihms opened this issue Aug 31, 2020 · 3 comments

Comments

@nabokihms
Copy link
Member

Sometimes it is helpful to see users' IP addresses in successful or failed authorization request log entries. This behavior can be achieved by using simple nginx in front of dex and looking into nginx logs, but it would be more convenient and simpler to see addresses in dex logs.

Maybe it's better to add this feature only for debug logging mode.
For example:

{"level":"info", "client_address":"192.168.0.1", "msg":"login successful: connector \"what-is-it\", username=\"Maksim Nabokikh\", preferred_username=\"maksim.nabokikh\", email=\"maksim.nabokikh@example.com\", groups=[]","time":"2020-08-31T14:41:31Z"}
@sagikazarmark
Copy link
Member

I'd definitely make that optional.....because GDPR.

@sagikazarmark
Copy link
Member

Note: need to be able to set trusted proxies to properly detect client IPs.

@nabokihms
Copy link
Member Author

closed by #3661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants