Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable throttling of OIDC connector requests on refresh tokens through using cached details #2113

Open
cehoffman opened this issue May 11, 2021 · 1 comment

Comments

@cehoffman
Copy link

Is your feature request related to a problem?

We have a need to reduce the number of requests going to the connector OIDC provider due to rate limiting.

Describe the solution you'd like to see

For our use case if Dex could throttle refresh token exchanges in a manner similar to the reuse interval it would cut down on upstream API calls and we can deal with slightly stale user state as cached from previous Dex claims. The issue with reuse interval is it isn't available when refresh token rotation is disabled and the simple solution would make refresh tokens requests act like keepalives and prevent checking with the upstream.

Describe alternatives you've considered

Enabling reuse interval and moving

old.ObsoleteToken = old.Token
to outside the rotation enabled check.

@nabokihms
Copy link
Member

Hello! Thanks for an interesting idea about the reuse interval use case. I have never thought that it has a positive impact in combination with disabled refresh token rotation.

However, we need to think a little more about a way to solve this issue. It seems like reuse interval is not the best solution we could find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants