Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up parsing into a single response_parse function #58

Open
cjrace opened this issue Oct 24, 2024 · 0 comments
Open

Tidy up parsing into a single response_parse function #58

cjrace opened this issue Oct 24, 2024 · 0 comments
Labels
enhancement Improvement to existing feature

Comments

@cjrace
Copy link
Contributor

cjrace commented Oct 24, 2024

Is your feature request related to a problem? Please describe.

Currently we have post_dataset() and get_dataset() both doing parsing independently, to reduce duplication and streamline our functions a bit for easier testing and maintenance we should break out a separate response_parse() eske function.

Describe the solution you'd like

A new function that handles the parsing for both post and get functions.

Describe alternatives you've considered

None, might be other approaches too.

Additional context

GitHub conversation on PR about this https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121

https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121
@cjrace cjrace added the enhancement Improvement to existing feature label Oct 24, 2024
@cjrace cjrace mentioned this issue Oct 24, 2024
Merged
@cjrace cjrace changed the title Tidy up parsing into a single response_parse functino Tidy up parsing into a single response_parse function Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjrace