Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first/last parameters for [person] #16

Closed
si-kotic opened this issue Jul 10, 2018 · 5 comments
Closed

first/last parameters for [person] #16

si-kotic opened this issue Jul 10, 2018 · 5 comments
Labels
enhancement

Comments

@si-kotic
Copy link

Excellent module! Very useful.

You should consider adding 'first' and 'last' as parameters for 'person' in the same way that you have 'male' and 'female'.
@dfinke
Copy link
Owner

dfinke commented Jul 10, 2018 •
edited
Loading

Want to try and change that? Do a PR?

@si-kotic
Copy link
Author

I'd love to, but I don't understand how it works.

I thought I was able to add the new parameter to the 'person' function however all I've done is break it and I can't fix it.

@dfinke
Copy link
Owner

dfinke commented Jul 11, 2018

Added. 0380961

@dfinke dfinke closed this as completed Jul 11, 2018
@si-kotic
Copy link
Author

Thank you, that's really helpful!

@dfinke
Copy link
Owner

dfinke commented Jul 11, 2018

Thanks for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfinke @si-kotic