You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is that "GenericSQL" prevents advance code assistance in PHPStorm, e.g.:
When I add MySQL Data Source (View | Tool Windows | Database) and I set SQL dialect to MySQL (Settings | Languages & Framewors | SQL Dialects), I can get code completion of table/column names + syntax check.
But it will not work when parameter has language attribute set to "GenericSQL" as it has higher priority over the dialect that is configured in settings.
If the attribute would have just "SQL" than configuration in settings is respected.
I see that GenericSQL dialect is useful as it does not report syntax errors for queries like this:
<?php$db->query('UPDATE foo SET %a', ['foo' => 'bar']);
But having it set in attribute, we loose the ability to change it on project/file bases. The only way is via PHPDoc for each query.
So I think using just SQL would be better as it gives more flexibility. I can set the dialect in the settings based on my needs.
The text was updated successfully, but these errors were encountered:
The issue is that "GenericSQL" prevents advance code assistance in PHPStorm, e.g.:
When I add MySQL Data Source (View | Tool Windows | Database) and I set SQL dialect to MySQL (Settings | Languages & Framewors | SQL Dialects), I can get code completion of table/column names + syntax check.
But it will not work when parameter has language attribute set to "GenericSQL" as it has higher priority over the dialect that is configured in settings.
If the attribute would have just "SQL" than configuration in settings is respected.
I see that GenericSQL dialect is useful as it does not report syntax errors for queries like this:
But having it set in attribute, we loose the ability to change it on project/file bases. The only way is via PHPDoc for each query.
So I think using just SQL would be better as it gives more flexibility. I can set the dialect in the settings based on my needs.
The text was updated successfully, but these errors were encountered: