-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets don't work past v8.5.x #1387
Comments
i have been having the same issue have u found any way around the problem? |
@qwtfy For the moment there doesn't seem to be a solution other than installing a previous version. 8.4 seems to work fine for my needs. In my experience serverless offline releases can be pretty buggy and have issues on one operating system but not another. I have tested 8.4 and it works well enough on windows for my needs but may have issues on mac os/linux. |
For our project
v8.3.1 seems to also work fine along with v8.4.0 for
|
I ran into this issue because I had a websocket authorizer set up, but wasn't returning a context on the policy. A workaround was to just return an empty object as the context on the policy. See #1472 |
@aardvarkk Unless I am misunderstanding something I don't believe it's the same issue. In my specific case I do not use any authorizer. Would you have an example function like I provided in my original post so that I can test? |
@TVGG If you're not using an authorizer then this wouldn't be the same issue. Just thought I'd add a comment in here to help people that are using one because it "broke" websockets for me until I made that PR to fix the issue. |
@aardvarkk Thanks for the clarification! |
#1381 was reverted in v8.8.0. could you check if your issue is gone?
it's possible that this is the same issue as that's how the handlers are run. |
@dnalborczyk The problem is still unresolved for the following config serverless version: 3.16.0 I have updated windows 10 since the initial post but considering the issue was my serverless-offline version last time it seems that the problem is still persists in v8.8.0. |
I'm closing this issue in the meanwhile as I believe there's multiple issues bing conflated. please open a new issue if the problem still persists. |
Websockets don't seem to work properly as of version 8.5.x.
All websocket routes appear as route '[object Object]'
When trying to connect via wscat the following happens:
Example route:
serverless version
: 3.16.0serverless-offline version
: 8.5.0node.js version
: 14.16.0OS
: win 10 build 19044.1645It might be related to issue #1381
The text was updated successfully, but these errors were encountered: