result of "sls offline start --exec 'exit 1'" doesn't return 1

[fffan64]

With serverless-offline 5.5.1:

foo@bar:~$ sls offline start --exec 'exit 1'
... serverless logs starting ...
Serverless: Halting offline server
foo@bar:~$ echo $?
0

With serverless-offline 3.16.0:

foo@bar:~$ sls offline start --exec 'exit 1'
... serverless logs starting ...
Serverless: Halting offline server
foo@bar:~$ echo $?
1

The --exec command doesn't care about the return code in recent version.

This is problematic if you use --exec to run your tests, as the exit code will always be 0 (no problem), and thus your pipeline will consider all tests pass correctly.

[fffan64]

look like i don't need start anymore in the command with --exec

After removing it, everything worked as expected

[sime]

Had this problem internally and I wanted to narrow down to the version that was causing this, though now I'm failing to reproduce.

$ sls create -t aws-nodejs -p slsoffline
$ cd slsoffline
$ yarn add serverless-offline@5.5.1
$ vim serverless.yml # (add serverless-offline as a plugin)
$ sls offline start --exec 'exit 1'
$ echo $?

Output of the last two commands.

$ sls offline --exec 'exit 1'
Serverless: Starting Offline: dev/us-east-1.

Serverless: Routes for hello:
Serverless: POST /{apiVersion}/functions/slsoffline-dev-hello/invocations

Serverless: Offline listening on http://localhost:3000
Serverless: Enter "rp" to replay the last request
Serverless: Offline executing script [exit 1]
Serverless: exec stdout: []
Serverless: exec stderr: []
Serverless: Offline error executing script [Error: Command failed: exit 1
]
Serverless: Halting offline server
$ echo $?
1