Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application dependency resolution doesn't work well #196

Closed
amcgee opened this issue Dec 3, 2019 · 2 comments · Fixed by #221
Closed

Application dependency resolution doesn't work well #196

amcgee opened this issue Dec 3, 2019 · 2 comments · Fixed by #221
Labels
bug Something isn't working released

Comments

@amcgee
Copy link
Member

amcgee commented Dec 3, 2019

Application dependencies aren't deduplicated with shell dependencies since #187, which can lead to duplicates in the bundle and React Hooks issues.

(credit @edoardo for pointing this out)

@amcgee
Copy link
Member Author

amcgee commented Dec 10, 2019

@varl and I discussed this and think we've outlined a solution. We'll move all runtime dependencies out of the shell and into the cli (d2-app-scripts), mimicking what react-scripts does, which should allow app source, app dependencies, and the shell itself to resolve identical dependencies.

@dhis2-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants