Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to @dhis2/ui v6 and bump other dependency versions #530

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 9, 2021

Related to DHIS2-9893

This bumps @dhis2/app-platform to use ui v6 which should have all the latest and greatest headerbar fixes.

BREAKING CHANGE: applications must use @dhis2/ui@^6.5.3

@amcgee amcgee requested a review from varl March 9, 2021 14:45
@varl
Copy link
Contributor

varl commented Mar 10, 2021

  1. Yes, getting feat: warn in development mode when query is missing paging or explicit fields app-runtime#788 in first would be nice since it is approved and would be fantastic to get propagated to all platform apps.
  2. Let's stick to releasing "technically" breaking changes as breaking changes, even if they do not require the user to change things. This discussion comes up every now and then, so I think we should stick to the process.

@amcgee amcgee changed the base branch from master to next March 11, 2021 00:44
@amcgee amcgee changed the base branch from next to master March 11, 2021 00:46
@amcgee amcgee changed the base branch from master to next March 11, 2021 00:46
@amcgee
Copy link
Member Author

amcgee commented Mar 11, 2021

@varl since we've addressed the points above and this has your tacit approval I'm merging it to next to test propagation to apps. You can approve or reject the subsequent merge to master.

@amcgee amcgee merged commit b8b72f4 into next Mar 11, 2021
@amcgee amcgee deleted the feat/ui-6 branch March 11, 2021 00:57
dhis2-bot added a commit that referenced this pull request Mar 11, 2021
# [6.0.0](v5.7.4...v6.0.0) (2021-03-11)

### Features

* upgrade to @dhis2/ui v6 and bump other dependency versions ([#530](#530)) ([b8b72f4](b8b72f4))

### BREAKING CHANGES

* applications must use @dhis2/ui@^6.5.3
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants