Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start plugin and app separately [LIBS-391] [LIBS-392] #848

Merged
merged 5 commits into from
May 30, 2024

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented May 27, 2024

Addresses LIBS-391 and LIBS-392:

  1. Runs a dev build with yarn start instead of a minified production build -- this was fixed by allowing multiple chunks to be made in the dev build
  2. Allows starting the app and the plugin separately -- the default behavior is still the same to avoid a breaking change, but you can now run yarn start --app to start just the app or yarn start --plugin to start just the plugin
    1. With the Vite changes, I think I will change the default to be to start just the app, then a user can pass the plugin flag to start just the plugin. It doesn't seem necessary to run both

Minified before & after:
minified-before
minified-after

New start script options:
new-start-script-options

@KaiVandivier KaiVandivier requested review from edoardo and a team May 27, 2024 16:15
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! 🚀

should we also update the documentation for the start command: https://github.com/dhis2/app-platform/blob/master/docs/scripts/start.md ?

@KaiVandivier KaiVandivier merged commit 82003e7 into master May 30, 2024
6 checks passed
@KaiVandivier KaiVandivier deleted the libs-392-plugin-dev-ex branch May 30, 2024 13:07
dhis2-bot added a commit that referenced this pull request May 30, 2024
# [11.3.0](v11.2.2...v11.3.0) (2024-05-30)

### Features

* start plugin and app separately [LIBS-391] [LIBS-392] ([#848](#848)) ([82003e7](82003e7))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 11.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Jun 20, 2024
# [12.0.0-alpha.2](v12.0.0-alpha.1...v12.0.0-alpha.2) (2024-06-20)

### Bug Fixes

* clean up for plugins [LIBS-620] ([#851](#851)) ([13af3b5](13af3b5))
* do not encode username, password ([#852](#852)) ([2fb4272](2fb4272))
* don't start plugins for apps without a plugin entrypoint ([#850](#850)) ([a89d4cf](a89d4cf))

### Features

* parse pluginType from d2 config to add to manifest.webapp ([#849](#849)) ([c1dae23](c1dae23))
* start plugin and app separately [LIBS-391] [LIBS-392] ([#848](#848)) ([82003e7](82003e7))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 12.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants