fix: don't update the package.json version before npm stage (#25)

* fix: don't update the package.json version before npm stage * chore: only update package version if we really want to * chore: override npm publish config instead of coupling plugins
dhis2 · Mar 25, 2019 · 5909f78 · 5909f78
1 parent d2c155e
commit 5909f78
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/packages/d2-app/src/commands/scripts/release.js b/packages/d2-app/src/commands/scripts/release.js
@@ -104,6 +104,7 @@ const handler = async ({ publish }) => {
             GIT_AUTHOR_EMAIL: 'ci@dhis2.org',
             GIT_COMMITTER_NAME: '@dhis2-bot',
             GIT_COMMITTER_EMAIL: 'ci@dhis2.org',
+            NPM_CONFIG_ALLOW_SAME_VERSION: 'true', // Ensure we still publish even though we've already updated the pacakge versions
         },
     }
 

diff --git a/packages/d2-app/src/commands/scripts/support/semantic-release-update-deps.js b/packages/d2-app/src/commands/scripts/support/semantic-release-update-deps.js
@@ -48,7 +48,7 @@ const prepare = (config, context) => {
     if (!context.packages) {
         verifyConditions({ ...config, silent: true }, context)
     }
-    const { silent, exact } = config
+    const { silent, exact, updatePackageVersion = true } = config
     const { nextRelease, logger, packages } = context
 
     const targetVersion = exact
@@ -60,13 +60,15 @@ const prepare = (config, context) => {
         const pkgJson = package.json
         const relativePath = path.relative(context.cwd, package.path)
 
-        pkgJson.version = nextRelease.version
-        if (!silent) {
-            logger.log(
-                `Updated version to ${nextRelease.version} for package ${
-                    package.label
-                } at ${relativePath}`
-            )
+        if (updatePackageVersion) {
+            pkgJson.version = nextRelease.version
+            if (!silent) {
+                logger.log(
+                    `Updated version to ${nextRelease.version} for package ${
+                        package.label
+                    } at ${relativePath}`
+                )
+            }
         }
 
         replaceDependencies(