Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow defer-release keyword in commit messages #161

Merged
merged 3 commits into from
Oct 16, 2019
Merged

feat: allow defer-release keyword in commit messages #161

merged 3 commits into from
Oct 16, 2019

Conversation

varl
Copy link
Contributor

@varl varl commented Oct 10, 2019

No description provided.

amcgee
amcgee approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amcgee
Copy link
Member

amcgee commented Oct 16, 2019

OPTIONAL - should we be a little more lax about the format? Something like message.toLowerCase().match(/[\s*defer[ -]release\s*]/g) could work, but maybe it's fine to leave it strict for now!

@varl
Copy link
Contributor Author

varl commented Oct 16, 2019

message.toLowerCase().match(/[\s*defer[ -]release\s*]/g)

It is an insensitive match (i), so there's some slack in what it accepts. I think the brackets should be escaped though, otherwise it lists the characters that it accepts. Not sure why we'd accept whitespace before/after the tag, but I do like the dash or space.

Will changed to /\[defer[ -]release\]/gi so these would match:

[defer release]
[defer-release]
[Defer Release]

@amcgee
Copy link
Member

amcgee commented Oct 16, 2019

Sounds good!

@varl varl merged commit ef6b385 into master Oct 16, 2019
@varl varl deleted the feat/defer-release branch October 16, 2019 16:54
dhis2-bot added a commit that referenced this pull request Oct 16, 2019
@dhis2-bot
chore(release): cut 2.5.0 [skip ci]
83f4997 
# [2.5.0](v2.4.0...v2.5.0) (2019-10-16)

### Features

* allow defer-release keyword in commit messages ([#161](#161)) ([ef6b385](ef6b385))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varl @amcgee @dhis2-bot