fix: align password help text with validation logic [DHIS2-15485] #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1131--dhis2-user.netlify.app |
tomzemp
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Approve. I couldn't find a ticket for this, but found the slack conversation that prompted this and created a ticket for it: https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15485
tomzemp
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Jun 27, 2023
## [1.5.21](v1.5.20...v1.5.21) (2023-06-27) ### Bug Fixes * align password help text with validation logic ([#1131](#1131)) ([e3e27de](e3e27de))
|
🎉 This PR is included in version 1.5.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tomzemp
pushed a commit
that referenced
this pull request
Jun 28, 2023
tomzemp
pushed a commit
that referenced
this pull request
Jun 28, 2023
tomzemp
pushed a commit
that referenced
this pull request
Jun 28, 2023
tomzemp
added a commit
that referenced
this pull request
Aug 14, 2023
tomzemp
added a commit
that referenced
this pull request
Sep 14, 2023
tomzemp
added a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted for this exact text because it is also being used in the replicate-model and the translations into many languages are already available.