fix: handle empty user roles response [DHIS2-15368] #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1215--dhis2-user.netlify.app |
tomzemp
changed the title
kabaros
approved these changes
Jun 22, 2023
dhis2-bot
added a commit
that referenced
this pull request
Jun 26, 2023
## [1.5.19](v1.5.18...v1.5.19) (2023-06-26) ### Bug Fixes * handle empty user roles response ([#1215](#1215)) ([0cf0218](0cf0218))
|
🎉 This PR is included in version 1.5.19 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tomzemp
added a commit
that referenced
this pull request
Jun 28, 2023
tomzemp
added a commit
that referenced
this pull request
Jun 28, 2023
tomzemp
added a commit
that referenced
this pull request
Jun 28, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15368
Front end expects response from api/user/{uid} to contain an object
userCredentialswhich contains an arrayuserRoles. However, when there are nouserRoles,userCredentialsdoes not contain the propertyuserRoles, and hence causes the app to crash (tries to map non-existentuserRolesarray)This arguably might be something the backend should change, but updating the front-end also is sufficient for the immediate purpose of stopping the app from crashing.
Note: we decided in our meeting on 20 June that we would fix this on the front end and backend team will evaluate if they also want to do anything here.