-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with latest version of Chrome or Chromedriver #21
Comments
Thanks for the report! I've confirmed that In what way does it not work after you've upgraded |
@dhleong Sorry it's taken me so long to response to this! When I update the
And looking at the Chrome window, it just is stuck on the login page in Mint during the auth process: |
@dhleong Any update on this? |
Sorry, I haven't had time to really look into this. I loaded mint in a normal browser just now, and that page doesn't seem to load into an iframe. Also, it's crazy that it can't find I had started rewriting in Typescript to make better use of promises and async/await, which might help. I'll see if I can find time to finish that. |
@KyleBastien I finished my Typescript rewrite (see #22). If you can, give that a shot and see if it improves anything for you! |
@KyleBastien I've just released v2.2.0 that includes the chromedriver update and typescript refactor. Please let me know if this improves the login stability for you! |
@dhleong Thank you very much for this! I apologize for me taking a long time to try this and get back! But this works fantastically! And I'm loving the new TypeScript types! Thank you again! |
Glad to hear :) |
Seems like the latest version of Chrome doesn't work with the version of Chromedriver this supports, it yells about only working with Chrome version 78.
Even if you do manually update the version of Chromedriver this is using to the latest version it seems to break because of not found element issues.
Possible that the not found element errors are related to (https://stackoverflow.com/questions/58589425/possible-issue-with-chromedriver-78-selenium-can-not-find-web-element-of-pdf-op) where Chrome no longer waits for iframe's to call the page "loaded".
My assumption being that Mint.com loads the initial login page inside of an iframe, which now this code goes through without finding any of the elements on the page.
The text was updated successfully, but these errors were encountered: