Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README refers to closed cargo PR #177

Open
jayvdb opened this issue Feb 1, 2023 · 2 comments
Open

README refers to closed cargo PR #177

jayvdb opened this issue Feb 1, 2023 · 2 comments

Comments

@jayvdb
Copy link

jayvdb commented Feb 1, 2023

README says

Support for a local registry is being added in rust-lang/cargo#2361 and will be able to redirect all Cargo downloads/requests to a registry stored locally.

That PR is closed, not merged.

The PR refers to rust-lang/cargo#2111 which was resolved when rust-lang/cargo#2811 was merged.

Digging through the PR a bit more I find rust-lang/cargo#2857 , which was merged and it looks like that is the feature the README in this repo should be mentioning instead of PR 2361, and I guess the tense of that sentence needs to change, and maybe the content of the sentence can also be updated.

@jayvdb
Copy link
Author

jayvdb commented Feb 1, 2023

Maybe the sentence can be reframed around https://doc.rust-lang.org/cargo/reference/source-replacement.html

@dhovart
Copy link
Owner

dhovart commented Apr 11, 2023

Thanks, will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants