Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.0.0 Missing theme files #174

Closed
k3nsei opened this issue Jul 15, 2024 · 3 comments · Fixed by #175
Closed

v18.0.0 Missing theme files #174

k3nsei opened this issue Jul 15, 2024 · 3 comments · Fixed by #175

Comments

@k3nsei
Copy link
Contributor

k3nsei commented Jul 15, 2024

image

image

image

X [ERROR] Can't find stylesheet to import.

3 │ @use './themes/base.scss';
  │ ^^^^^^^^^^^^^^^^^^^^^^^^^

  node_modules\@dhutaryan\ngx-mat-timepicker\_timepicker-theme.scss 3:1  @forward
  node_modules\@dhutaryan\ngx-mat-timepicker\_index.scss 1:1             @use
@k3nsei k3nsei changed the title Missing theme files Missing theme files v18 Jul 15, 2024
@k3nsei k3nsei changed the title Missing theme files v18 v18.0.0 Missing theme files Jul 15, 2024
@dhutaryan dhutaryan linked a pull request Jul 15, 2024 that will close this issue
@k3nsei
Copy link
Contributor Author

k3nsei commented Jul 15, 2024

@dhutaryan thanks for quick response

@dhutaryan
Copy link
Owner

Sorry, I've totally forgot to include new files into build. Fixed in 18.0.1

@k3nsei
Copy link
Contributor Author

k3nsei commented Jul 15, 2024

It's totally ok, easy mistake to do. As including assets it's not common thing to do.
@dhutaryan Don't forget to mark previous package version as deprecated, because without those assets present it's unusable.

image

Here are instructions how to do that:
https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions#deprecating-a-single-version-of-a-package

@k3nsei k3nsei closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants