Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

fix(avatar): overlay icon alignment #1115

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

juliodialpad
Copy link
Contributor

Fix (Avatar): Overlay icon alignment

πŸ› οΈ Type Of Change

  • Fix
  • Feature
  • Refactoring
  • Documentation

πŸ“– Description

Added justify-content: center to be sure the icon is always at the center of the overlay regarding its size.

πŸ’‘ Context

Issues on product with icon alignment where reported and tried to fix it here but it was better to add the fix on the actual avatar instead of just the recipe.

πŸ“ Checklist

  • I have reviewed my changes
  • I have added tests
  • I have added all relevant documentation
  • I have validated components with a screen reader
  • I have validated components keyboard navigation
  • I have considered the performance impact of my change
  • I have checked that my change did not significantly increase bundle size
  • I am exporting any new components or constants in the index.js in the component directory
  • I am exporting any new components or constants in the index.js in the root

πŸ“· Screenshots / GIFs

image

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thanks for contributing to Dialtone Vue! Please read below for some important info regarding Vue 3 compatibility.

Currently we need to maintain two branches in Dialtone Vue, one for Vue 2, one for Vue 3.

This means you must create two PRs for every feature change you make. One into staging and one into staging-vue3.

Many times the change you have made in Vue 2 will be identical to the change you need to make in Vue 3. To make this easier we have made a script that can copy your changes from this branch to a new branch off of staging-vue3 suffixed with -vue3.

run ./copy_pr_vue3.sh from the root dialtone-vue directory.

Once the new branch is created, you will need to look at your code to make sure it still makes sense and test that your changes all work in vue 3. If everything is good you can push it and create a PR into staging-vue3.

It is a required check for every PR to have a corresponding branch called yourbranch-vue3 so that we do not forget to do it. In the special case that you need to make a change to vue2 without making it in vue3, you can set the label vue2-only on this PR.

I got "commit SHA is a merge but no -m option was given."

This happens if there are merge commits in your branch. It's no problem, you can simply skip them with git cherry-pick --skip. We don't want to copy merge commits to the Vue 3 branch.

What if I make more changes to my vue 2 branch after running ./copy_pr_vue3.sh?

You can copy these to the existing -vue3 branch by running the script with a git SHA param like so:

./copy_pr_vue3.sh 2a78db7

where 2a78db7 is the last commit from your branch that was copied to the other branch (all commits after this will be copied)

If it's just one or two commits, you may prefer to just manually use git cherry-pick which will work fine as well.

What if I get a conflict?

It's possible to get a conflict when running copy_pr_vue3.sh as there are differences in Vue 2 and Vue 3 code. If this happens you can manually fix the conflict, commit it and do git cherry-pick --continue.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

βœ”οΈ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1115/
πŸ”¨ If you experience an SSL issue then wait 2 minutes and try again.

@iropolo
Copy link
Contributor

iropolo commented Aug 9, 2023

cc @fabiangarga

@github-actions github-actions bot added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Aug 9, 2023
@juliodialpad
Copy link
Contributor Author

Accessibility tests are broken due to the recent color update on links I think @francisrupert @fede-dp

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

βœ”οΈ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1115/
πŸ”¨ If you experience an SSL issue then wait 2 minutes and try again.

@juliodialpad juliodialpad merged commit 5670057 into staging Aug 9, 2023
10 of 11 checks passed
@juliodialpad juliodialpad deleted the fix/avatar/overlay-icon-alignment branch August 9, 2023 17:34
juliodialpad pushed a commit that referenced this pull request Aug 9, 2023
## [2.93.2](v2.93.1...v2.93.2) (2023-08-09)

### Bug Fixes

* **Avatar:** overlay icon alignment ([#1115](#1115)) ([5670057](5670057))
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

πŸŽ‰ This PR is included in version 2.93.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants