-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Thanks for contributing to Dialtone Vue! Please read below for some important info regarding Vue 3 compatibility. Currently we need to maintain two branches in Dialtone Vue, one for Vue 2, one for Vue 3. This means you must create two PRs for every feature change you make. One into Many times the change you have made in Vue 2 will be identical to the change you need to make in Vue 3. To make this easier we have made a script that can copy your changes from this branch to a new branch off of staging-vue3 suffixed with -vue3. run Once the new branch is created, you will need to look at your code to make sure it still makes sense and test that your changes all work in vue 3. If everything is good you can push it and create a PR into It is a required check for every PR to have a corresponding branch called I got "commit SHA is a merge but no -m option was given."This happens if there are merge commits in your branch. It's no problem, you can simply skip them with What if I make more changes to my vue 2 branch after running ./copy_pr_vue3.sh?You can copy these to the existing -vue3 branch by running the script with a git SHA param like so:
where 2a78db7 is the last commit from your branch that was copied to the other branch (all commits after this will be copied) If it's just one or two commits, you may prefer to just manually use What if I get a conflict?It's possible to get a conflict when running |
βοΈ Deploy Preview ready! |
cc @fabiangarga |
Accessibility tests are broken due to the recent color update on links I think @francisrupert @fede-dp |
βοΈ Deploy Preview ready! |
## [2.93.2](v2.93.1...v2.93.2) (2023-08-09) ### Bug Fixes * **Avatar:** overlay icon alignment ([#1115](#1115)) ([5670057](5670057))
π This PR is included in version 2.93.2 π The release is available on GitHub release Your semantic-release bot π¦π |
Fix (Avatar): Overlay icon alignment
π οΈ Type Of Change
π Description
Added
justify-content: center
to be sure the icon is always at the center of the overlay regarding its size.π‘ Context
Issues on product with icon alignment where reported and tried to fix it here but it was better to add the fix on the actual avatar instead of just the recipe.
π Checklist
π· Screenshots / GIFs