Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin prospector version to avoid pyroma install error #424

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Pin prospector version to avoid pyroma install error #424

merged 1 commit into from
Dec 6, 2022

Conversation

loostrum
Copy link
Member

@loostrum loostrum commented Dec 6, 2022

Closes #423

@loostrum loostrum requested a review from egpbos December 6, 2022 12:10
egpbos
egpbos approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@egpbos egpbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looketh goode to me.

I would recommend adding an issue to remind of this and to again unpin (or != this particular version) when the upstream bug is fixed.

@cwmeijer cwmeijer mentioned this pull request Dec 6, 2022
Merged
@cwmeijer cwmeijer merged commit d07f815 into main Dec 6, 2022
@cwmeijer cwmeijer deleted the 423-pin-prospector branch December 6, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egpbos egpbos egpbos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linting CI is broken
3 participants
@loostrum @egpbos @cwmeijer