Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin prospector #442

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Unpin prospector #442

merged 1 commit into from
Jan 17, 2023

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Jan 11, 2023

Version 1.8.4 should have fixed the issues previously mentioned in #423. See https://github.com/PyCQA/prospector/milestone/7?closed=1. Also relevant to the discussion in NLeSC/python-template#327

Version 1.8.4 should have fixed the issues previously mentioned in #423.
See https://github.com/PyCQA/prospector/milestone/7?closed=1.
@egpbos egpbos requested a review from loostrum January 11, 2023 12:36
@egpbos
Copy link
Member Author

egpbos commented Jan 11, 2023

The linter runs, so I think this should be considered an improvement over pinning the old version? The failures are due to actual linter suggestions, which I guess are a separate issue :)

Copy link
Member

@loostrum loostrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good that the linter is running again. I agree with unpinning prospector and creating a separate issue for the linting problems. The pylint version pin was unrelated, that was already there before the prospect pin. I don't know why and I'm tempted to just unpin pylint as well, because I don't see why it was pinned in the first place.

@egpbos
Copy link
Member Author

egpbos commented Jan 16, 2023

Oh right, I didn't check if pylint was necessary to unpin. Is that then causing (some of) the linting failures now? Anyway, may indeed be good to unpin as well, especially if there's no reason to keep it pinned, but maybe someone else knows why it was pinned, @cwmeijer or @elboyran?

@cwmeijer
Copy link
Member

I don't remember anything about pinning prospector. It doesn't seem sensible to me to pin the version of a well maintained linter package. Unpin it :-)

@cwmeijer cwmeijer mentioned this pull request Jan 17, 2023
@cwmeijer cwmeijer merged commit b065dc3 into main Jan 17, 2023
@elboyran elboyran deleted the unpin_prospector branch March 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants