Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to jQuery 2 #6557

Closed
ghost opened this issue Nov 21, 2015 · 8 comments
Closed

Upgrade to jQuery 2 #6557

ghost opened this issue Nov 21, 2015 · 8 comments
Labels
♻️ code refactor
Milestone
0.6.0.0

Comments

@ghost
Copy link

ghost commented Nov 21, 2015 •
edited by jhass
Loading

diaspora currently relies on jQuery 1.11.2. Nothing stops us to upgrade to jQuery 2.1.4 except diaspora_jsxc which requires exactly 1.11.2. I just tested which a patched version of the diaspora_jsxc locally, everything seems to work well. @zauberstuhl, do you have an opposition onn patching diaspora_jxsc so we can upgrade to jQuery 2?
@svbergerem
Copy link
Member

jQuery 2.x has the same API as jQuery 1.x, but does not support Internet Explorer 6, 7, or 8. [...] Since IE 8 is still relatively common, we recommend using the 1.x version unless you are certain no IE 6/7/8 users are visiting the site.

Is there any reason why we should switch to jQuery 2.x?

@Flaburgan
Copy link
Member

@svbergerem we don't actually support IE 6/7/8 at all. I don't know about the current code but 3 years ago diaspora* wasn't working at all with those browsers and we didn't work on this since that moment, so I assume this is not a blocker.

@ghost
Copy link
Author

ghost commented Nov 22, 2015

Is there any reason why we should switch to jQuery 2.x?

jQuery 2.x code is lighter so I suppose that improves performance. Originally, this is related to #6555 which uses Hammer.JS. The jQuery plugin depends on jQuery 2. This is not really blocking as I've just copied the file in vendor/assets/javascripts instead of using th rails-asset gem, but I though it could be interresting to raise this issue to discuss the topic.

I don't know about the current code but 3 years ago diaspora* wasn't working at all with those browsers

We use flexboxes in CSS which are not even well supported by IE10 so I guess jQuery is not our first compatibility problem ;)

@zauberstuhl
Copy link
Contributor

that could hurt. but I can try it in the next few days. also I have to talk with upstream about it

diaspora/jsxc#134

@zauberstuhl
Copy link
Contributor

//adding @pravi

he is currently checking if we can use jquery 2 out of the box with the debian package

@ghost
Copy link
Author

ghost commented Feb 17, 2016

Ping.

@ghost ghost mentioned this issue Feb 18, 2016
Closed
@pravi
Copy link
Contributor

pravi commented Mar 12, 2016

@AugierLe42e https://github.com/diaspora/jsxc/issues/134#issuecomment-160160358

SuperTux88 added a commit to SuperTux88/diaspora that referenced this issue Mar 14, 2016
@SuperTux88
remove ChromeFrame
2354b49 
Google Chrome Frame was a plugin for Internet Explorer, but is no longer
supported. And it was included with http and not https which triggered a
warning on most pods.

Also set the minimum version to 9 to support diaspora#6557
@SuperTux88 SuperTux88 mentioned this issue Mar 14, 2016
Closed
SuperTux88 added a commit to SuperTux88/diaspora that referenced this issue Mar 14, 2016
@SuperTux88
remove ChromeFrame
8a489da 
Google Chrome Frame was a plugin for Internet Explorer, but is no longer
supported. And it was included with http and not https which triggered a
warning on most pods.

Also set the minimum version to 9 to support diaspora#6557
SuperTux88 added a commit to SuperTux88/diaspora that referenced this issue Mar 18, 2016
@SuperTux88
remove ChromeFrame
5dd6dcf 
Google Chrome Frame was a plugin for Internet Explorer, but is no longer
supported. And it was included with http and not https which triggered a
warning on most pods.

Also set the minimum version to 9 to support diaspora#6557
jhass pushed a commit that referenced this issue Mar 21, 2016
@SuperTux88 @jhass
remove ChromeFrame
d97448e 
Google Chrome Frame was a plugin for Internet Explorer, but is no longer
supported. And it was included with http and not https which triggered a
warning on most pods.

Also set the minimum version to 9 to support #6557

closes #6751
@ghost ghost mentioned this issue Aug 7, 2016
Merged
@svbergerem svbergerem added this to the 0.6.0.0 milestone Aug 9, 2016
@svbergerem
Copy link
Member

Fixed by #6944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♻️ code refactor
Projects
None yet
Milestone
0.6.0.0
Development

No branches or pull requests
5 participants
@jhass @zauberstuhl @pravi @Flaburgan @svbergerem