Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple line-height units #2952

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

diegomura
Copy link
Owner

Closes: #2851
Closes: #2469

@diegomura diegomura self-assigned this Nov 17, 2024
Copy link

changeset-bot bot commented Nov 17, 2024

🦋 Changeset detected

Latest commit: 94d4ec8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@react-pdf/layout Patch
@react-pdf/stylesheet Patch
@react-pdf/renderer Patch
next-14 Patch
next-15 Patch
@react-pdf/vite-example Patch
@react-pdf/e2e-node-cjs Patch
@react-pdf/e2e-node-esm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@diegomura diegomura merged commit 2c3c887 into master Nov 17, 2024
@diegomura diegomura deleted the dm/fix-line-height branch November 17, 2024 16:21
natterstefan added a commit to traveltechdeluxe/react-pdf that referenced this pull request Dec 6, 2024
# By Diego Muracciole (31) and others
# Via GitHub
* upstream/master: (60 commits)
  feat: allow units for page size (diegomura#2773)
  chore: bump jay-peg
  chore: release packages (diegomura#2981)
  fix(textkit): make indentation only affect first line. (diegomura#2975)
  fix: conditional rendering (diegomura#2983)
  fix(reconciler): missing dependencies (diegomura#2980)
  chore: release packages (diegomura#2959)
  feat: rem border widths (diegomura#2960)
  fix: add scheduler dependency (diegomura#2958)
  chore: update README
  chore: release packages (diegomura#2953)
  feat: support rem units (diegomura#2955)
  feat: add image stress test example (diegomura#2954)
  feat: support multiple line-height units (diegomura#2952)
  chore: release packages (diegomura#2946)
  fix: note rendering (diegomura#2951)
  feat: accept commas between transformations (diegomura#2950)
  fix: document metadata setters (diegomura#2949)
  fix: stroke dash array computation (diegomura#2948)
  feat: remove cross-fetch (diegomura#2947)
  ...

# Conflicts:
#	packages/renderer/index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: lineHeight can't accept length or percentage lineHeight error
1 participant