Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If using relative path, images in target webpage is not loaded properly. #160

Open
qutang opened this issue Nov 10, 2017 · 1 comment
Open

Comments

@qutang
Copy link

qutang commented Nov 10, 2017

If src of any image tags in the target webpage is relative (e.g. images/img.png instead of /webpage_path/images/img.png), it is not loaded correctly by instantclick. Browser console returns 404 on the image link. I think it's because the url used to fetch images is not updated. In other words, the images should be fetched based on target webpage's url.

This problem is solved using absolute path, but sometimes relative path is more convenient when the webpage url is generated automatically.

@silasabbott
Copy link

silasabbott commented Jan 5, 2018

UPDATE: My issue with css files is probably different than this issue. I realized instantclick.js doesn't reload anything inside the tag, so if there is a new css file in the next page, it won't load it when preloading the that page.

I've had this same issue with some CSS files. My home page and main css is in the root, but when navigating from the home page to another page that is located one directory down, there is a css file that won't load. When I refresh the page, it loads as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants