Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 target refinement? #85

Open
robertleeplummerjr opened this issue Oct 16, 2017 · 2 comments
Open

v1 target refinement? #85

robertleeplummerjr opened this issue Oct 16, 2017 · 2 comments

Comments

@robertleeplummerjr
Copy link

@differentmatt ty so much for your hard work on this project! I've been able to review in depth the internals of filbert, and what it accomplishes. I was hoping to open communication between The OpenMined project for assisting with this project so to facilitate growth towards v1. In it's current state, there is much code in place to assist with getting the ast to run in javascript, and while I think that is a fantastic concept, I would like to see what is thought about splitting that behavior into two items:

  1. An ast parser, that just parses ast's as a pseudo javascript reference
  2. An ast translator (or caster) that changes the ast to be compatible with an environment

Thoughts welcome!

@basicer
Copy link
Collaborator

basicer commented Oct 28, 2017

Hey @robertleeplummerjr

Checkout skulpty, it has the sort of separation your talking about. It also uses the skulpt parser instead of acorn, so it's a little bit more complete.

https://github.com/codecombat/skulpty

@differentmatt
Copy link
Owner

Hi @robertleeplummerjr,

I'm open to working with you and @OpenMined on this project, including separating behaviors as you suggest.

You may want to check out the skulpty project @basicer referenced first, since it's probably a stronger base for what you're looking for. At @codecombat we switched from filbert to skulpty about a year ago for our in-browser Python needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants