Don't reuse BufStep args across invocations #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
changed the title
nedtwigg
reviewed
Dec 24, 2023
| } | ||
| List<String> args = List.of(exeAbsPath, "format", file.getAbsolutePath()); |
There was a problem hiding this comment.
What about just args.set(2, file.getAbsolutePath()? I think exe.confirmVersionAndGetAbsolutePath(); is fairly expensive, and I don't think we need to call it for every invocation.
There was a problem hiding this comment.
I refactored to only call confirmVersionAndGetAbsolutePath once - did you see that?
There was a problem hiding this comment.
Good call, looks nice. Sorry for slow turnaround.
nedtwigg
approved these changes
Jan 14, 2024
| } | ||
| List<String> args = List.of(exeAbsPath, "format", file.getAbsolutePath()); |
There was a problem hiding this comment.
Good call, looks nice. Sorry for slow turnaround.
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1779 introduced a regression where the same args will be reused across all invocations to Buf, resulting in Spotless returning garbage for every file except the first during a lint run.
I'm actually not sure what the best way to test this is. Is there a test harness or template that can check multiple files in one plugin run? I should be able to add a failing test that this PR fixes that way.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)