Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Path Support for spotlessFiles #531

Closed
t-rad679 opened this issue Feb 24, 2020 · 4 comments
Closed

Relative Path Support for spotlessFiles #531

t-rad679 opened this issue Feb 24, 2020 · 4 comments

Comments

@t-rad679
Copy link
Contributor

As discussed extensively from this comment in issue 529 onward, it would be nice to add some kind of support for specifying relative paths in spotlessFiles, which currently only works with absolute paths. The documentation should be very clear about how this will function in all cases, including what directory the path should be relative to.

After some discussion in the other ticket, I think it makes the most sense for the path to be relative to the root directory of the root project.

@nedtwigg
Copy link
Member

Whatever discussion or work happens in service of this ticket, please make sure that it is driven by a usecase that you have. E.g. you are connecting to a tool and it is difficult to generate the absolute paths which are currently neeeded. If you have a usecase, and can solve your problem without creating new problems for the people who are already using the -PspotlessFiles feature, then you can merge whatever.

@nedtwigg nedtwigg mentioned this issue May 4, 2020
@nedtwigg
Copy link
Member

nedtwigg commented May 6, 2020

With the work happening in #568, I'm more convinced than ever that relative path support is likely to cause problems. I think this issue is mostly driven by frustration with the surprising regex behavior, which is a separate problem.

@nedtwigg nedtwigg closed this as completed May 6, 2020
@t-rad679
Copy link
Contributor Author

Ok, sounds good! Thanks, Ned!

@nedtwigg
Copy link
Member

nedtwigg commented Jun 5, 2020

FYI, -PspotlessFiles has been deprecated and will be removed. Migration path available here: #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants