Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatterStep.NeedsFile #637

Merged
merged 7 commits into from
Jul 2, 2020
Merged

FormatterStep.NeedsFile #637

merged 7 commits into from
Jul 2, 2020

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Jul 2, 2020

We've had a few steps that require the file to operate

Our FormatterFunc really discourages that, so each step has had to make its own local hack. This PR adds FormatterFunc.NeedsFile, which consolidates all these hacks into one place. Minor cleanup, just FYI.

@nedtwigg nedtwigg merged commit 86c6f96 into main Jul 2, 2020
@nedtwigg nedtwigg deleted the feat/formatter-step-cleanup branch July 2, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant