Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small fixes to language switcher #326

Merged
merged 5 commits into from
Apr 8, 2020
Merged

fix: Small fixes to language switcher #326

merged 5 commits into from
Apr 8, 2020

Conversation

gmaclennan
Copy link
Member

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations. Please submit translation changes via our Mapeo Crowdin project
  • My commits are in nice logical chunks with good commit messages
  • I have walked through the QA Manual Testing
    Script
    and updated it if necessary.
  • If my changes depend upon an update to a dependency, I have updated the package-lock.json file using npm install --package-lock
  • My changes have been tested with the mobile app.
  • My changes are ready to be shipped to users on Windows, Mac, and Linux

Description

Some small fixes to the language switch dialog:

  • Show the currently selected locale
  • Allow the user to cancel language switch

Also wrote code to change language without a force-refresh, but our iD Editor integration with React was unhappy (iD re-renders everything when you switch language, and we have a React component patched into the iD toolbar).

@okdistribute okdistribute merged commit bb493db into master Apr 8, 2020
@okdistribute okdistribute deleted the locale-fixes branch April 8, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants