Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide generic geometry presets in territory #621

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

rudokemper
Copy link
Member

Contributor checklist:

  • My contribution is not related to translations. Please submit translation changes via our Mapeo Crowdin project
  • My commits are in nice logical chunks with good commit messages
  • I have walked through the QA Manual Testing Script and updated it if necessary.
  • If my changes depend upon an update to a dependency, I have updated the package-lock.json file using npm install --package-lock
  • My changes have been tested with the mobile app.
  • My changes are ready to be shipped to users on Windows, Mac, and Linux using the production version of the application built with electron-builder.

Description

Resolves #620

Forgot to add conventional commits format initially, so rewrote the commit messaging - hence the multiple commits. Will squash when merging upon approval.

@rudokemper rudokemper self-assigned this Nov 8, 2021
@rudokemper rudokemper changed the title 620: Hide generic geometry presets in territory fix: Hide generic geometry presets in territory Nov 8, 2021
@ErikSin
Copy link
Contributor

ErikSin commented Nov 10, 2021

@rudokemper Can you rebase this (And Let me know if you want to any support with rebasing)?

@rudokemper rudokemper force-pushed the rk/620/hide-generic-geometry-presets-in-territory branch from 839e78e to 1201455 Compare November 10, 2021 12:47
@rudokemper
Copy link
Member Author

@ErikSin done. Do ya'll merge or should I?

@ErikSin
Copy link
Contributor

ErikSin commented Nov 10, 2021

I can do it rn! But in general, It doesn't matter who merges it, as long as someone has approved it!

@ErikSin ErikSin merged commit 34fc54f into master Nov 10, 2021
@ErikSin ErikSin deleted the rk/620/hide-generic-geometry-presets-in-territory branch November 10, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding generic geometry presets in Territory
3 participants