Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get window from DOCUMENT injection token #121

Open
tom-odb opened this issue Mar 22, 2019 · 0 comments
Open

Get window from DOCUMENT injection token #121

tom-odb opened this issue Mar 22, 2019 · 0 comments
Labels
good first issue Ideal for your first contribution!

Comments

@tom-odb
Copy link
Contributor

tom-odb commented Mar 22, 2019 •
edited
Loading

Describe the bug

The WindowService still just attempts to access the global window. We should instead use the defaultView, available on the native document, which returns the native window in a browser environment. Since an InjectionToken for document is already provided by Angular, we can remove this dependency on a global variable.

To Reproduce

/

Expected behavior

Don't use global variables.

Screenshots

/

OS (please complete the following information):

/

Additional context

Add any other context about the problem here.
@tom-odb tom-odb added the good first issue Ideal for your first contribution! label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tom-odb