From 0883bc1a479a1c4e29c2e5991d63cf30f545c6fc Mon Sep 17 00:00:00 2001 From: George Goodall Date: Wed, 4 Dec 2024 12:05:20 +0000 Subject: [PATCH] content changes re alex feedback --- src/middleware/common.middleware.js | 2 +- src/middleware/entryIssueDetails.middleware.js | 4 ++-- test/unit/middleware/entryIssueDetails.middleware.test.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/middleware/common.middleware.js b/src/middleware/common.middleware.js index def10d2d..ebc62aed 100644 --- a/src/middleware/common.middleware.js +++ b/src/middleware/common.middleware.js @@ -618,7 +618,7 @@ export function getErrorSummaryItems (req, res, next) { if (issue.reference && !specialIssueTypeCases.includes(issue.issue_type)) { inString = ` in entity with reference ${issue.reference}` } else if (issue.line_number) { - inString = ` in row ${issue.line_number}` + inString = ` on row ${issue.line_number}` } return { html: performanceDbApi.getTaskMessage({ issue_type: issueType, num_issues: 1, field: issueField }) + inString, diff --git a/src/middleware/entryIssueDetails.middleware.js b/src/middleware/entryIssueDetails.middleware.js index 182bda35..8f6cf9fc 100644 --- a/src/middleware/entryIssueDetails.middleware.js +++ b/src/middleware/entryIssueDetails.middleware.js @@ -91,7 +91,7 @@ export const prepareEntry = (req, res, next) => { fields: [ { key: { - text: 'Endpoint' + text: 'Endpoint URL' }, value: { html: `${resources[0].endpoint_url}` @@ -100,7 +100,7 @@ export const prepareEntry = (req, res, next) => { }, { key: { - text: 'Line number' + text: 'Row' }, value: { html: issue.line_number.toString() diff --git a/test/unit/middleware/entryIssueDetails.middleware.test.js b/test/unit/middleware/entryIssueDetails.middleware.test.js index 32ead566..1ac73d14 100644 --- a/test/unit/middleware/entryIssueDetails.middleware.test.js +++ b/test/unit/middleware/entryIssueDetails.middleware.test.js @@ -99,12 +99,12 @@ describe('entryIssueDetails.middleware.test.js', () => { title: 'entry: 1', fields: [ { - key: { text: 'Endpoint' }, + key: { text: 'Endpoint URL' }, value: { html: 'https://example.com' }, classes: '' }, { - key: { text: 'Line number' }, + key: { text: 'Row' }, value: { html: '2' }, classes: '' },