Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue details: Fetch data from all active resources #684

Closed
26 of 27 tasks
GeorgeGoodall-GovUk opened this issue Nov 21, 2024 · 0 comments · Fixed by #707
Closed
26 of 27 tasks

Issue details: Fetch data from all active resources #684

GeorgeGoodall-GovUk opened this issue Nov 21, 2024 · 0 comments · Fixed by #707
Assignees
Labels
enhancement New feature or request Spill over Identifies tickets not completed in sprint and have been carried over into next sprint

Comments

@GeorgeGoodall-GovUk
Copy link
Contributor

GeorgeGoodall-GovUk commented Nov 21, 2024

the issues and pagination on this page are generated by looking at issues from only the latest resource on the latest endpoint, ideally we want to consider all active resources

look at #600 for more context

Additional tasks

  • breadcrumbs on this page?
  • No data pulled through to entity view page.
  • Entity link from table going to wrong entity - see, e.g., from this page, clicking on entity ref TPO632_T173 links to this page for entity ref TPO632_G36

refactoring

  • extract getBaseSubPath into common middleware
  • extract getDataRange into common middleware
  • extract getIssueErrorSummary into common middleware (and rename to specify its specifically for pipeline issues)
    • write new middleware to set required params for getIssueErrorSummary

Testing

  • Common.middleware.js

    • getBaseSubPath
    • getDataRange
    • getIssueErrorSummary
  • entityIssueDetails.middleware.js

    • prepareEntity
    • set record count
    • prepareEntityIssueDetailsTemplateParams
  • entryIssueDetails.middeware.js

    • addResourceMetaDataToResources
    • setRecordCount
    • prepareEntry
    • prepareEntryIssueDetailsTemplateParams
    • getIssueDetail
  • issueTableMiddleware.test.js

    • set record count
  • dataviewTableMiddleware.test.js

    • set record count
  • Additional Changes

    • pagination, should say showing 1 - 50
    • error summary should always follow the pattern
      There is a problem
      x rows have issue```
      or
      There is a problem
      all rows have issue
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk converted this from a draft issue Nov 21, 2024
@CharliePatterson CharliePatterson added the enhancement New feature or request label Nov 22, 2024
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk self-assigned this Nov 27, 2024
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk moved this from Eng sprint backlog to In Development in Submit and update planning data service Nov 28, 2024
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk linked a pull request Nov 29, 2024 that will close this issue
8 tasks
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk moved this from In Development to Code review & QA in Submit and update planning data service Dec 3, 2024
@github-project-automation github-project-automation bot moved this from Code review & QA to Done in Submit and update planning data service Dec 9, 2024
@GeorgeGoodall-GovUk GeorgeGoodall-GovUk moved this from Done to Ready for release in Submit and update planning data service Dec 9, 2024
@neilfwar neilfwar added the Spill over Identifies tickets not completed in sprint and have been carried over into next sprint label Dec 10, 2024
@DilwoarH DilwoarH moved this from Ready for release to Done in Submit and update planning data service Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spill over Identifies tickets not completed in sprint and have been carried over into next sprint
Projects
Development

Successfully merging a pull request may close this issue.

3 participants