Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export lib and jk generate friendly default export separately? #17

Open
shimmerjs opened this issue Oct 11, 2020 · 0 comments
Open

Export lib and jk generate friendly default export separately? #17

shimmerjs opened this issue Oct 11, 2020 · 0 comments

Comments

@shimmerjs
Copy link
Contributor

At the moment, because the function exported from ./lib which defines the manifests for that component is called unconditionally in index.ts to support running jk generate directly, if there are required parameters that are asserted, library consumers (i.e., people who import the ./lib function by way of index.ts) will face runtime errors. Either

a) all components must be able to be rendered without any provided parameters

or

b) library users should import ./lib directly and not import index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant