Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not produce Signature for Responses #15

Open
aljones15 opened this issue Aug 9, 2019 · 0 comments
Open

Can not produce Signature for Responses #15

aljones15 opened this issue Aug 9, 2019 · 0 comments
Assignees
Labels
bug Something isn't working Priority 2 Important but not critical

Comments

@aljones15
Copy link
Contributor

aljones15 commented Aug 9, 2019

Not sure if this library was intended to, but

api.createSignatureString = ({includeHeaders, requestOptions} = {}) => {
assert.object(requestOptions, 'requestOptions');
assert.object(requestOptions.headers, 'requestOption.headers');
assert.string(requestOptions.method, 'requestOption.method');
assert.string(requestOptions.url, 'requestOption.url');
assert.optionalArrayOfString(includeHeaders, 'headers');

currently createSignatureString needs a method argument passed in.
Response HTTP Messages do not specify a method so
we either need to re-use the request's method (if available) or
allow createSignatureString to operate with out one. We could do both.
Basically we are not handling the case where a response message is signed with
(request-target) in the Signature headers parameter.

@aljones15 aljones15 added the bug Something isn't working label Aug 16, 2019
@mandyvenables mandyvenables added the Priority 2 Important but not critical label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority 2 Important but not critical
Projects
None yet
Development

No branches or pull requests

3 participants